jscheffl commented on code in PR #67226:
URL: https://github.com/apache/airflow/pull/67226#discussion_r3283917687
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -1109,6 +1111,31 @@ def _clean(self, event: dict[str, Any], result: dict |
None, context: Context) -
result=result,
)
+ def _push_xcom_with_fan_out(self, ti: Any, value: Any) -> None:
+ """Push ``return_value`` and, when ``multiple_outputs`` is set, also
fan a dict out per key.
+
+ Mirrors the task runner's ``_push_xcom_if_needed`` so the failure-path
manual pushes
+ in ``cleanup`` (sync) and ``trigger_reentry`` (async) honour
``multiple_outputs`` —
+ previously they pushed only ``return_value``, silently dropping
per-key fan-out.
+ On success both paths return the value and let the runner perform the
push instead.
+ """
+ if not value:
Review Comment:
If the value evaluates to `False` would not persist. Can you change to
explicit NULL check?
```suggestion
if value is not None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
