mik-laj commented on a change in pull request #6957: [AIRFLOW-6396] Use tempfile.TemporaryDirectory instead of custom one URL: https://github.com/apache/airflow/pull/6957#discussion_r361879124
########## File path: airflow/utils/file.py ########## @@ -17,32 +17,14 @@ # specific language governing permissions and limitations # under the License. -import errno import os import re -import shutil import zipfile -from contextlib import contextmanager -from tempfile import mkdtemp from typing import Dict, List, Optional, Pattern from airflow import LoggingMixin, conf Review comment: Can you maintain backward compatibility to make migrations easier for users? I think I don't need to take drastic steps and immediately delete this function without warning. I think that changes should always be done in several stages: - initial version - initial version with a deprecation warning - remove features. We can make changes to Airflow 2.0 that are not backward compatible, but these should be individual exceptions, but not the only way to make changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
