mik-laj commented on a change in pull request #6957: [AIRFLOW-6396] Use 
tempfile.TemporaryDirectory instead of custom one
URL: https://github.com/apache/airflow/pull/6957#discussion_r361879497
 
 

 ##########
 File path: airflow/utils/file.py
 ##########
 @@ -17,32 +17,14 @@
 # specific language governing permissions and limitations
 # under the License.
 
-import errno
 import os
 import re
-import shutil
 import zipfile
-from contextlib import contextmanager
-from tempfile import mkdtemp
 from typing import Dict, List, Optional, Pattern
 
 from airflow import LoggingMixin, conf
 
 
 
 Review comment:
   We can shorten this path if we suspect that users do not use this function, 
but I think that this does not apply in this case..  This PR introduces changes 
to 13 files, so this is a commonly used function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to