johanjk opened a new pull request, #67447:
URL: https://github.com/apache/airflow/pull/67447
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
# Chart support EnableServiceLinks
EnableServiceLinks is a source of subtle bugs, it introduces env vars that
can conflict with user env vars etc.
It's also noisy, pollutes the env, and increase pod startup time.
Make it configurable in the chart, and default to false
It is open for debate if the default should stay true, as some users might
technically rely on it existing.
Hence it can be seen as a breaking change. I am open to keeping the default
true.
## Testing
Tested with `helm template chart` for `enableServiceLinks: true/false`.
## Current workaround
```yaml
postRenders:
- kustomize:
patches:
- target:
version: v1
kind: Deployment
patch: |
- op: add
path: /spec/template/spec/enableServiceLinks
value: false
- target:
version: v1
kind: CronJob
patch: |
- op: add
path: /spec/jobTemplate/spec/template/spec/enableServiceLinks
value: false
```
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
