eladkal commented on PR #67340: URL: https://github.com/apache/airflow/pull/67340#issuecomment-4532774072
> > Airflow's Tableau provider currently allows` tableauserverclient>=0.27`, but the incremental keyword argument was only introduced in `tableauserverclient v0.35`. Since thispr always passes `incremental `for refresh calls, users with a supported older version such as v0.34 will hit `TypeError`, even when `incremental_refresh=False.` > > fyi: https://github.com/tableau/server-client-python/releases > > You are right about the version issue i have actually addressed this in the latest commit using runtime signature inspection to detect if the incremental parameter is supported for older versions that don't have it we just fall back to calling without the parameter and log a warning. So it's backward compatible with 0.27 and works with all versions up to 0.37 you can raise `AirflowOptionalProviderFeatureException` telling users that their current version doesn't support the feature. raising warning is not helpful as you can not recover from this issue unless you upgrade. example: https://github.com/apache/airflow/blob/4d3c5ead3b570f9c6a395d7aa63d856270fc5619/providers/amazon/src/airflow/providers/amazon/aws/auth_manager/cli/avp_commands.py#L29-L35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
