eladkal commented on code in PR #67340:
URL: https://github.com/apache/airflow/pull/67340#discussion_r3301688174
##########
providers/tableau/src/airflow/providers/tableau/operators/tableau.py:
##########
@@ -124,6 +139,18 @@ def execute(self, context: Context) -> str:
if not job_items:
raise ValueError("Tableau tasks.run returned no JobItem in
response")
job_id = job_items[0].id
+ elif self.method == "refresh":
+ if self.incremental_refresh:
+ try:
+ response = method(resource_id, incremental=True)
+ except TypeError:
+ raise AirflowOptionalProviderFeatureException(
+ "Incremental refresh requires
tableauserverclient>=0.35. "
+ "Please upgrade: pip install
'tableauserverclient>=0.35'"
+ )
Review Comment:
are we sure the only reason for TypeError is that?
If not then we need to inspect the message or at lease raise the original
error message so users can see full traceback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
