SameerMesiah97 commented on code in PR #67626:
URL: https://github.com/apache/airflow/pull/67626#discussion_r3314654560
##########
providers/dbt/cloud/tests/unit/dbt/cloud/operators/test_dbt.py:
##########
@@ -210,7 +210,8 @@ def
test_execute_deferrable_does_not_pass_execution_timeout_to_defer(
execution_timeout=timedelta(seconds=3),
)
- dbt_op.execute(MagicMock())
+ with patch("airflow.providers.dbt.cloud.operators.dbt.time.time",
return_value=1000.0):
+ dbt_op.execute(MagicMock())
Review Comment:
This change is not strictly needed as the purpose of this test was to ensure
that a non-`None` value is not passed as a parameter to the `execution_timeout`
argument (it was causing a premature timeout preventing the DBT job from being
cancelled on reaching the `execution_deadline`). So the actual value is not
relevant (that's why `ANY` was used before). Not a blocking concern but in
general we want to avoid touching unrelated tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
