Revanth14 commented on PR #67626: URL: https://github.com/apache/airflow/pull/67626#issuecomment-4561142507
> The fix looks correct. Tests need to be adjusted of course. I have left a few comments. > > Also, I see that you have adjusted an unrelated test, which isn't necessarily a blocking concern but it does make the test slightly less focused. I was just curious why you made that change. Thanks for the review. You are right about the operator test. I changed it because I initially wanted to assert that the operator computed the serialized trigger deadlines from `time.time()` by checking the exact values passed to the trigger. But I agree that this made the existing test less focused, since its purpose is really to verify `defer(timeout=None)` behavior and that a trigger deadline is passed. I restored it to use `ANY` and kept the clock-specific assertion in the new trigger regression test instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
