ibobgunardi opened a new pull request, #68000:
URL: https://github.com/apache/airflow/pull/68000

   Generated airflowctl commands expand request-body models into CLI flags, but 
required Pydantic fields were still optional to argparse. That let the command 
reach request-body validation before telling the user what was missing.
   
   This passes `field_info.is_required()` through when building those flags, so 
commands like `connections create` report missing required fields as normal CLI 
arguments.
   
   closes: #57721
   
   Tests:
   - `.venv\Scripts\python.exe -m pytest 
airflow-ctl\tests\airflow_ctl\ctl\test_cli_config.py -q 
--confcutdir=airflow-ctl\tests\airflow_ctl\ctl`
   - `.venv\Scripts\python.exe -m py_compile 
airflow-ctl\src\airflowctl\ctl\cli_config.py 
airflow-ctl\tests\airflow_ctl\ctl\test_cli_config.py`
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (OpenAI Codex)
   
   Generated-by: OpenAI Codex following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to