amoghrajesh opened a new pull request, #68274:
URL: https://github.com/apache/airflow/pull/68274
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### What
Related to https://github.com/apache/airflow/pull/66859
`serialize_task_store_to_ref` and `serialize_asset_store_to_ref` on
`BaseStoreBackend` previously received `ti_id: str` (a UUID) and `asset_ref:
str` respectively. A new `ti_id` is issued on every task retry, so any object
storage path derived from it would be different per retry, that means that a
job ID written by try 1 would be unreachable by try 2 when a backend tries to
reconnect to an existing external job (the primary use case for a custom
backend, e.g. `ResumableJobMixin`).
### Current behaviour
`serialize_task_store_to_ref` receives a UUID (`ti_id`) that changes each
retry. A custom backend deriving its storage path from `ti_id` produces a
different path per retry, orphaning values written by previous tries.
Similarly, `serialize_asset_store_to_ref` receives a plain string (`asset_ref`)
that loses the distinction between name and URI.
### Proposed change
Both methods now receive a scope object - `TaskScope` (dag_id, run_id,
task_id, map_index) for the task variant and `AssetScope` (name, uri) for the
asset variant.
The scope is stable across retries for the same logical task instance, so a
custom backend can derive a deterministic, retry-stable path. The `AssetScope`
change also lets backends correctly distinguish name vs URI when constructing
paths.
`context.py` call sites updated to pass `self._scope` (task) and
`AssetScope(name=..., uri=...)` (asset) instead of the previous string values.
### Testing
Check in the diff, InMemoryStoreBackend is an implementation
- Updated `InMemoryStoreBackend` in `test_context.py` to implement the new
signatures, constructing a `mem://dag/run/task/map_index/key` path from the
full `TaskScope` matching the structure a real object storage backend would use.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
