Lee-W commented on code in PR #68274:
URL: https://github.com/apache/airflow/pull/68274#discussion_r3380533574
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -715,10 +716,10 @@ def set(self, key: str, value: JsonValue) -> None:
# if custom backend is configured, store the value on the custom
backend, and return the reference
# to the stored value to store in the DB
backend = _get_worker_state_store_backend()
- asset_ref = self._name or self._uri or ""
stored: JsonValue = value
if backend is not None:
- ref = backend.serialize_asset_store_to_ref(value=value, key=key,
asset_ref=asset_ref)
+ scope = AssetScope(name=self._name, uri=self._uri)
+ ref = backend.serialize_asset_store_to_ref(value=value, key=key,
scope=scope)
Review Comment:
I kinda forgot why it was named as `asset_ref`, but we do have `AssetRef`.
would be nice if we could rename or check whether this can be accessed by users
so it won't be confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
