pierrejeambrun commented on code in PR #68340:
URL: https://github.com/apache/airflow/pull/68340#discussion_r3394444069
##########
airflow-core/src/airflow/ui/src/pages/MappedTaskInstance/MappedTaskInstance.tsx:
##########
@@ -41,11 +41,12 @@ export const MappedTaskInstance = () => {
const tabs = [
{ icon: <MdOutlineTask />, label: `${translate("tabs.taskInstances")}
[${taskCount}]`, value: "" },
+ { icon: <MdDetails />, label: translate("tabs.details"), value: "details"
},
];
return (
<ReactFlowProvider>
- <DetailsLayout tabs={tabs}>
+ <DetailsLayout outletContext={taskInstance} tabs={tabs}>
Review Comment:
This is to re-use the Grid summary. Otherwise the detail tab will have to
`useGridTiSummariesStream` but since this is a stream, it's a custom impl, not
re-using react query cache and all.
So basically opening a new stream to fetch the TI summaries again.
This allow to share the stream from the grid into the details view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
