pierrejeambrun commented on code in PR #68340:
URL: https://github.com/apache/airflow/pull/68340#discussion_r3394444069
##########
airflow-core/src/airflow/ui/src/pages/MappedTaskInstance/MappedTaskInstance.tsx:
##########
@@ -41,11 +41,12 @@ export const MappedTaskInstance = () => {
const tabs = [
{ icon: <MdOutlineTask />, label: `${translate("tabs.taskInstances")}
[${taskCount}]`, value: "" },
+ { icon: <MdDetails />, label: translate("tabs.details"), value: "details"
},
];
return (
<ReactFlowProvider>
- <DetailsLayout tabs={tabs}>
+ <DetailsLayout outletContext={taskInstance} tabs={tabs}>
Review Comment:
This is to re-use the Grid summary. Otherwise the detail tab will have to
`useGridTiSummariesStream` to fetch the TI summary. But since this is a stream,
it's a custom implementation, not re-using react query cache and all, so this
would open a second stream request to get the TI summaries.
This allow to share the stream from the grid view with the details view, via
a context.
Preventing a second call to `useGridTiSummariesStream` and preventing a
second stream request for data we already have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
