potiuk commented on code in PR #68633:
URL: https://github.com/apache/airflow/pull/68633#discussion_r3424897874
##########
.github/workflows/ci-image-checks.yml:
##########
@@ -160,6 +160,15 @@ jobs:
- name: "Show prek log on failure"
run: cat ~/.cache/prek/prek.log || true
if: failure()
+ - name: "Check commit messages are not Conventional Commits"
+ if: github.event_name == 'pull_request'
+ run: >
+ gh api
+ "repos/${{ github.repository }}/pulls/${{
github.event.pull_request.number }}/commits"
+ --paginate -q '.[].commit.message | split("\n")[0]'
+ | ./scripts/ci/prek/check_no_conventional_commit_message.py
--from-stdin
Review Comment:
Not exactly - there is often difference between committ messages and what
is going to be merged with our **squash & merge** case. How it works is that
when the PR is just one commit - the description is indeed the commit message -
but when PR has more than one commit, the message is what is in the PR
title/description. Often even the last message is just "fixup" or "applying
changes from review - so getting PR is the right one.
Speaking of whicn - what thos one gets is **not** that ... so I have to fix
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
