potiuk commented on code in PR #68633:
URL: https://github.com/apache/airflow/pull/68633#discussion_r3424945738
##########
.github/workflows/ci-image-checks.yml:
##########
@@ -160,6 +160,15 @@ jobs:
- name: "Show prek log on failure"
run: cat ~/.cache/prek/prek.log || true
if: failure()
+ - name: "Check commit messages are not Conventional Commits"
+ if: github.event_name == 'pull_request'
+ run: >
+ gh api
+ "repos/${{ github.repository }}/pulls/${{
github.event.pull_request.number }}/commits"
+ --paginate -q '.[].commit.message | split("\n")[0]'
+ | ./scripts/ci/prek/check_no_conventional_commit_message.py
--from-stdin
Review Comment:
Good point on squash & merge — switched the CI check to validate the PR
title (read from an env var, so no API call and no injection risk from a
crafted title). The individual `commit-msg` hook still guards local commits.
Done in 18b0568.
---
Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
