shahar1 commented on code in PR #67621:
URL: https://github.com/apache/airflow/pull/67621#discussion_r3447348740
##########
providers/google/src/airflow/providers/google/cloud/sensors/pubsub.py:
##########
@@ -113,7 +113,7 @@ def __init__(
project_id: str,
subscription: str,
max_messages: int = 5,
- return_immediately: bool = True,
+ return_immediately: bool = False,
Review Comment:
Same comment applies to the rest of the changed operators:
As long as this field is still usable, I'd rather deprecate it slowly from
Airflow to prevent sudden changes for Airflow's users. According to the Google
provider [deprecation
policy](https://airflow.apache.org/docs/apache-airflow-providers-google/stable/deprecation-policy.html#additional-considerations),
we usually allow 6 months until making breaking changes - but since this is
already deprecated in the API and might already cause unwanted behavior, I'm
fine with breaking it in the version after the deprecation is released (about a
month from now).
Let's change the default back to `True`, but with a deprecation warning that
it will be changed to `False` in the next breaking version.
When it's published that the feature is finally removed from the API, we
could also remove the field entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
