MaksYermak commented on PR #67621:
URL: https://github.com/apache/airflow/pull/67621#issuecomment-4769131708

   > Thanks for your contribution and apologies for the delay in response!
   > 
   > CC: @VladaZakharova @MaksYermak - I'll appreciate your opinion here, 
thanks!
   
   @shahar1 thank you for letting us know!
   
   I agree with you that for this code the default value should change back to 
`True`. 
   
   **About deprecation.**
   We already had had deprecation warning for this code in the past and 
`return_immediately` parameter was removed by this 
https://github.com/apache/airflow/pull/23231. After that because of 
[issue](https://github.com/apache/airflow/issues/41838) in `PubSubPullSensor ` 
it was retuned back by this https://github.com/apache/airflow/pull/41842. The 
current PR extends the usage for this deprecated parameter in my opinion it 
does not make sense because it is deprecated and can be removed any time. But I 
think we need to make investigate what we can use instead of this parameter for 
being sure that after removing the `PubSubPullSensor` will work as expect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to