pierrejeambrun commented on code in PR #64611:
URL: https://github.com/apache/airflow/pull/64611#discussion_r3452838101
##########
task-sdk/src/airflow/sdk/execution_time/comms.py:
##########
@@ -1115,6 +1116,7 @@ class GetAssetEventByAssetAlias(BaseModel):
before: AwareDatetime | None = None
limit: int | None = None
ascending: bool = True
+ extra: dict[str, str] | None = None
Review Comment:
Do we need a cadwyn migration? To remove that field from 'more recent sdk'
talking to an old server?
##########
airflow-core/src/airflow/migrations/versions/0123_3_3_0_add_gin_index_on_asset_event_extra.py:
##########
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""
+Add GIN index on asset_event.extra for PostgreSQL.
+
+Revision ID: 5a5d3253e946
+Revises: 9ff64e1c35d3
+Create Date: 2026-04-01 23:00:00.000000
+
+"""
+
+from __future__ import annotations
+
+from alembic import op
+from sqlalchemy import text
+
+# revision identifiers, used by Alembic.
+revision = "5a5d3253e946"
+down_revision = "9ff64e1c35d3"
+branch_labels = None
+depends_on = None
+airflow_version = "3.3.0"
+
+
+def upgrade():
+ """Add GIN index on asset_event.extra for PostgreSQL only."""
+ conn = op.get_bind()
+ if conn.dialect.name == "postgresql":
+ op.execute(
+ text(
+ "CREATE INDEX IF NOT EXISTS idx_asset_event_extra_gin "
+ "ON asset_event USING GIN ((extra::jsonb) jsonb_ops)"
+ )
+ )
Review Comment:
Could this take forever on a big asset event table ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
