phanikumv commented on code in PR #68929:
URL: https://github.com/apache/airflow/pull/68929#discussion_r3464708044
##########
task-sdk/src/airflow/sdk/coordinators/java/coordinator.py:
##########
@@ -174,14 +174,13 @@ class JavaCoordinator(SubprocessCoordinator):
Configuration is taken from the ``[sdk] coordinators`` entry that
constructs
this instance::
- {
- "name": "jdk-17",
+ "jdk-17": {
"classpath": "airflow.sdk.coordinators.java.JavaCoordinator",
"kwargs": {
- "java_executable": "/usr/lib/jvm/java-17-openjdk/bin/java",
- "jvm_args": ["-Xmx1024m"],
"jars_root": ["~/airflow/jars"],
- },
+ "java_executable": "/usr/lib/jvm/java-17-openjdk/bin/java",
Review Comment:
The broken example (missing required `jars_root`) went unnoticed because
nothing exercises the config.yml coordinators example. A tiny test that loads
this example through CoordinatorManager and asserts each entry constructs would
stop this drifting again. I am ok to leave this for a follow-up though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
