jason810496 commented on code in PR #68929:
URL: https://github.com/apache/airflow/pull/68929#discussion_r3464836122
##########
task-sdk/src/airflow/sdk/coordinators/java/coordinator.py:
##########
@@ -174,14 +174,13 @@ class JavaCoordinator(SubprocessCoordinator):
Configuration is taken from the ``[sdk] coordinators`` entry that
constructs
this instance::
- {
- "name": "jdk-17",
+ "jdk-17": {
"classpath": "airflow.sdk.coordinators.java.JavaCoordinator",
"kwargs": {
- "java_executable": "/usr/lib/jvm/java-17-openjdk/bin/java",
- "jvm_args": ["-Xmx1024m"],
"jars_root": ["~/airflow/jars"],
- },
+ "java_executable": "/usr/lib/jvm/java-17-openjdk/bin/java",
Review Comment:
Good idea to make the example doc won't drift. Addressed in
e70c9f8e3350feac940fb1f8be5d191557bffcca.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
