xBis7 commented on code in PR #67424:
URL: https://github.com/apache/airflow/pull/67424#discussion_r3467401333
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -1056,7 +1069,17 @@ def is_effective_leaf(task):
leaf_tis = {ti for ti in tis if ti.task_id in leaf_task_ids if
ti.state != TaskInstanceState.REMOVED}
return leaf_tis
- def _emit_dagrun_span(self, state: DagRunState):
+ def _should_force_root_dagrun_span(self) -> bool:
Review Comment:
When is a dag run span supposed to not be root? Who should have triggered it?
What happens if we add a new span under the scheduler and the scheduler
triggers a dag_run, whose span isn't root? The span is going to be a child of
the scheduler's span. Is it something we want to do or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
