ashb commented on code in PR #67424:
URL: https://github.com/apache/airflow/pull/67424#discussion_r3468253007
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -1056,7 +1069,17 @@ def is_effective_leaf(task):
leaf_tis = {ti for ti in tis if ti.task_id in leaf_task_ids if
ti.state != TaskInstanceState.REMOVED}
return leaf_tis
- def _emit_dagrun_span(self, state: DagRunState):
+ def _should_force_root_dagrun_span(self) -> bool:
Review Comment:
I agree. I think the dag run should be the root span, not the web request
which creates it.
A link between the dag run root span and the request span would make sense,
but to me putting the dag run spans under this API just doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
