SameerMesiah97 commented on code in PR #69005:
URL: https://github.com/apache/airflow/pull/69005#discussion_r3483061423
##########
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:
##########
Review Comment:
Are we sure we don't want to tag this one? My understanding is that this
metric (if tagged by team) could help measure workload distribution across
teams. Doesn't make sense to exclude it. But check with @ferruzzi first.
##########
providers/edge3/tests/unit/edge3/executors/test_edge_executor.py:
##########
@@ -120,6 +120,38 @@ def test_sync_orphaned_tasks(self, mock_stats_incr):
assert jobs[0].task_id == "started_running_orphaned"
assert jobs[0].state == TaskInstanceState.REMOVED
+ @patch(f"{Stats.__module__}.Stats.timer")
Review Comment:
I would add this here:
```
@pytest.mark.skipif(
not AIRFLOW_V_3_2_PLUS,
reason="team_name is only available in Airflow 3.3+",
)
```
I would double-check the exact version with @ferruzzi. Looking at this PR:
https://github.com/apache/airflow/pull/55003
It looks like `team_name` was added to `BaseExecutor` just before 3.1 was
released but I am not sure if that means it is officially supported for 3.1. So
it could be either `not AIRFLOW_V_3_1_PLUS` or `not AIRFLOW_V_3_2_PLUS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
