ferruzzi commented on code in PR #69005:
URL: https://github.com/apache/airflow/pull/69005#discussion_r3484285153
##########
providers/edge3/tests/unit/edge3/executors/test_edge_executor.py:
##########
@@ -120,6 +120,38 @@ def test_sync_orphaned_tasks(self, mock_stats_incr):
assert jobs[0].task_id == "started_running_orphaned"
assert jobs[0].state == TaskInstanceState.REMOVED
+ @patch(f"{Stats.__module__}.Stats.timer")
Review Comment:
This part is always tricky. I am pretty sure the right answer is `not
AIRFLOW_V_3_1_PLUS` in general, but Edge's airflow version support is
`apache-airflow>=3.0.0,!=3.1.0`. Since team_name doesn't exist on 3.0, and the
provider doesn't support 3.1.0, I think we should use `not AIRFLOW_V_3_2_PLUS`
on this one, and 3.1+ in the others (unless they also exclude 3.1 explicitly)
(Edited for clarity)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
