Revanth14 commented on issue #69065: URL: https://github.com/apache/airflow/issues/69065#issuecomment-4815125059
Thanks for opening this. My 2 cents here I'm +1 on handling this as one coherent 3.4.0 migration rather than rushing it into 3.3.0. One extra thing worth considering: FastAPI 0.137.2 added [`iter_route_contexts()`](https://github.com/fastapi/fastapi/releases/tag/0.137.2) for advanced use cases that previously inspected `router.routes`- exactly the category our failing guards fall into. That makes this cheaper than it first looks: rather than a minor-version jump, we'd only bump the lower bound from `>=0.137.1` to `>=0.137.2` and use FastAPI's helper as the shared introspection primitive. The fallback is to keep `>=0.137.1` and add a small local compatibility helper with equivalent behavior, but given the patch-level cost, I'd lean toward the upstream primitive. I also agree the token-scope tests should not be weakened. They should keep asserting the same policy, just over the effective route tree instead of the old flat `router.routes` list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
