ferruzzi commented on issue #69065: URL: https://github.com/apache/airflow/issues/69065#issuecomment-4835295086
Another thought, and it's entirely possible this maybe scope creep and should be ignored, but I'll drop it here in case the migration ends up making this relevant: The sole reason the token scope tests have `isinstance(route, APIRoute)` is to make MyPy happy. Technically, the `router.routes` iterator I used in those tests is typed as `list[BaseRoute]` so it can return a couple other types which Airflow never implemented (WebSocketRoute, Mount, Host, and I feel like there is another I'm forgetting at the moment). If the new official helper changes that return type, it is possible that it may require changes elsewhere. Or if we end up making our own helper then maybe we can scope it down to just the APIRoute type we actually use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
