ephraimbuddy commented on code in PR #61550:
URL: https://github.com/apache/airflow/pull/61550#discussion_r3485787039
##########
airflow-core/src/airflow/serialization/definitions/dag.py:
##########
@@ -672,6 +693,9 @@ def create_dagrun(
partition_key=partition_key,
partition_date=partition_date,
note=note,
+ bundle_version=bundle_version,
+ dag_version=dag_version,
+ resolved_dag=params_dag if bundle_version is not None else None,
Review Comment:
In line 702 below, deadline processing is gated on `self.deadline`, where
`self` is still the latest Dag. If `v1 `has a Dag-level deadline and `v2`
removes it, triggering `bundle_version="v1"` creates a run pinned to `v1` but
skips creating deadline rows. This should use the resolved Dag version, not the
latest Dag object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
