uranusjr commented on PR #68629: URL: https://github.com/apache/airflow/pull/68629#issuecomment-4862578131
(Still from Claude) `GetAssetEventByAsset.Ascending` and `GetAssetEventByAssetAlias.Ascending` are `bool` with `omitempty` and schema default `true`. The pointer widening in `pointerizedFields` only covers `builtinIntTypes` — `bool` is not in that set. So `Ascending: false` would be dropped on encode (Go zero for `bool`), and the supervisor would apply its default of `true`, silently reversing the caller's intent. This is the same bug class as the original `int`+`omitempty` problem, just for a bool field. It's latent — `GetAssetEventByAsset` isn't called from `client.go` yet — but the `pointerizedFields` logic should be extended to cover `bool` fields with `default: true` for the same reason it covers integer fields with non-zero defaults. Or at minimum, the decode-side tests for `Ascending` should be paired with an encode-side test that confirms `false` is preserved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
