jason810496 commented on PR #68629: URL: https://github.com/apache/airflow/pull/68629#issuecomment-4862608277
> GetAssetEventByAsset.Ascending and GetAssetEventByAssetAlias.Ascending are bool with omitempty and schema default true. The pointer widening in pointerizedFields only covers builtinIntTypes — bool is not in that set. So Ascending: false would be dropped on encode (Go zero for bool), and the supervisor would apply its default of true, silently reversing the caller's intent. Yes, good point. I only considered the `int`, `null`, `-1` semantic issue in last round but didn't considered `bool`. I will verify all primitive type myself then mark as ready to review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
