Prab-27 opened a new pull request, #69317:
URL: https://github.com/apache/airflow/pull/69317

   `airflowctl connections create` shows Traceback (most recent call last):
    ```
    airflowctl connections create
   Please enter password for encrypted keyring: 
   Traceback (most recent call last):
     File "/usr/python/bin/airflowctl", line 10, in <module>
       sys.exit(main())
     File "/opt/airflow/airflow-ctl/src/airflowctl/__main__.py", line 34, in 
main
       safe_call_command(args.func, args=args)
     File "/opt/airflow/airflow-ctl/src/airflowctl/ctl/cli_config.py", line 77, 
in safe_call_command
       function(args)
     File "/opt/airflow/airflow-ctl/src/airflowctl/api/client.py", line 532, in 
wrapper
       return func(*args, api_client=api_client, **kwargs)
     File "/opt/airflow/airflow-ctl/src/airflowctl/ctl/cli_config.py", line 
731, in _get_func
       method_params[datamodel_param_name] = datamodel.model_validate(
     File "/usr/python/lib/python3.10/site-packages/pydantic/main.py", line 
732, in model_validate
       return cls.__pydantic_validator__.validate_python(
   pydantic_core._pydantic_core.ValidationError: 2 validation errors for 
ConnectionBody
   connection_id
     Input should be a valid string [type=string_type, input_value=None, 
input_type=NoneType]
       For further information visit 
https://errors.pydantic.dev/2.13/v/string_type
   conn_type
     Input should be a valid string [type=string_type, input_value=None, 
input_type=NoneType]
       For further information visit 
https://errors.pydantic.dev/2.13/v/string_type
   
   ```
   Make `connection_id` and `conn_type` as required parameter in connections 
operations  and update tests 
   
   
   … tests
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to