SameerMesiah97 commented on code in PR #69317:
URL: https://github.com/apache/airflow/pull/69317#discussion_r3521603333
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -444,8 +444,7 @@ def list(self) -> ConnectionCollectionResponse |
ServerResponseError:
return super().execute_list(path="connections",
data_model=ConnectionCollectionResponse)
def create(
- self,
- connection: ConnectionBody,
+ self, connection: ConnectionBody, connection_id: str, conn_type: str
Review Comment:
I'm not sure I understand why `connection_id` and `conn_type` need to be
separate required parameters here. They're already required fields on
`ConnectionBody`, so this duplicates the source of truth and allows them to
diverge. Is there a reason we can't continue deriving these values from the
`ConnectionBody` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
