nailo2c commented on code in PR #69586:
URL: https://github.com/apache/airflow/pull/69586#discussion_r3585304650
##########
providers/google/src/airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -633,6 +633,7 @@ def set_current_job(current_job):
poll_sleep=self.poll_sleep,
impersonation_chain=self.impersonation_chain,
cancel_timeout=self.cancel_timeout,
+ drain_pipeline=self.drain_pipeline,
Review Comment:
I noticed `cancel_on_kill` is added to the triggers, but the Dataflow
operators do not expose or pass it when creating the trigger. Does that mean
users cannot actually set `cancel_on_kill=False` through the operator path?
##########
providers/google/src/airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -793,6 +794,7 @@ def execute(self, context: Context) -> dict[str, Any]:
cancel_timeout=self.cancel_timeout,
expected_terminal_state=self.expected_terminal_state,
impersonation_chain=self.impersonation_chain,
+ drain_pipeline=self.drain_pipeline,
),
Review Comment:
Same as the comment in `TemplateJobStartTrigger`.
##########
providers/google/src/airflow/providers/google/cloud/operators/dataflow.py:
##########
Review Comment:
I think this PR make it works in deferrable mode so the docstring should
also fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
