jason810496 commented on code in PR #70059: URL: https://github.com/apache/airflow/pull/70059#discussion_r3612693723
########## java-sdk/adr/0006-no-lang-sdk-source-display.md: ########## @@ -0,0 +1,140 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + +# ADR-0006: No Lang-SDK Source Code Display for Mixed-Language (`@task.stub`) Dags + +## Status + +Proposed + +> **Note:** This ADR records a *negative* decision. It exists so that future feature requests +> or PRs proposing multi-file / multi-language source display for stub-backed Dags can be +> pointed here instead of re-litigating the design. Tracked operationally in +> [apache/airflow#67260](https://github.com/apache/airflow/issues/67260), which is closed as +> won't-fix referencing this document. + +## Context + +Per [AIP-108](https://cwiki.apache.org/confluence/x/pY4mGQ), Java tasks are declared as +`@task.stub` operators in ordinary Python Dag files: the Dag is defined in Python, while the +task implementation lives in a Java-SDK build artifact (a JAR) shipped in the same bundle. We +call this a **mixed-language Dag**. This is distinct from pure Java Dags +([ADR-0003](0003-pure-java-dags.md)), where the Dag itself is defined in Java and the Review Comment: Currently, all ADRs in `java-sdk/adr` are in "Proposed" state, I should fix this. The `pure-java-dags` will be addendum of AIP-108 and the upcoming AIP-85. Anyway, this feature doesn't impact the `pure-java-dags` feature at all. They're independent actually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
