Andrushika commented on code in PR #70951:
URL: https://github.com/apache/airflow/pull/70951#discussion_r3703574834
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -529,6 +530,12 @@ def ti_update_state(
task_id=task_id,
)
+ # Release the task_instance row lock before running listener callbacks.
+ session.commit()
+
+ for callback in asset_callbacks:
Review Comment:
Nit: Previously, listeners ran after each event was created. Now their
callbacks are collected and run only after all outlets have been processed.
If the second outlet fails with a non-DB error, an event already created for
the first outlet can still be committed, but its callbacks are lost because the
function never returns them.
(This may be fine since listeners are best effort, just to confirm that this
is intentional)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
