uranusjr commented on code in PR #70951:
URL: https://github.com/apache/airflow/pull/70951#discussion_r3710915299
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -529,6 +530,12 @@ def ti_update_state(
task_id=task_id,
)
+ # Release the task_instance row lock before running listener callbacks.
+ session.commit()
+
+ for callback in asset_callbacks:
Review Comment:
Right, and this is why the follow-up PR is needed. After #70972, if
something fails midway during registration, the entire trasaction will be
rolled back; no events will be registered with no callbacks run, which is
consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
