aaron-y-chen commented on code in PR #69749:
URL: https://github.com/apache/airflow/pull/69749#discussion_r3725398199


##########
providers/google/tests/unit/google/cloud/hooks/vertex_ai/test_generative_model.py:
##########
@@ -23,6 +23,7 @@
 
 # For no Pydantic environment, we need to skip the tests
 pytest.importorskip("google.cloud.aiplatform_v1")
+pytest.importorskip("vertexai.preview.evaluation")

Review Comment:
   I noticed that the CI image installs via `uv sync --all-packages --group 
ci-image` (`Dockerfile.ci`, no `--all-extras`), so this skip fires there, and 
the only tests in these two files are `test_run_evaluation` and 
`TestVertexAIRunEvaluationOperator::test_execute`, i.e. exactly the paths this 
PR guards. Is that intended?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to