Vamsi-klu commented on code in PR #69749:
URL: https://github.com/apache/airflow/pull/69749#discussion_r3755550287
##########
providers/google/tests/unit/google/cloud/hooks/vertex_ai/test_generative_model.py:
##########
@@ -23,6 +23,7 @@
# For no Pydantic environment, we need to skip the tests
pytest.importorskip("google.cloud.aiplatform_v1")
+pytest.importorskip("vertexai.preview.evaluation")
Review Comment:
The branch is rebased onto current main and is no longer conflicting.
On your question: the `importorskip` is gone, so both evaluation-path test
files run in the default CI image, and the `MetricPromptTemplateExamples`
fallback engages only on `ImportError`, so an environment that does have the
extra still exercises the real values.
Being straight about what I could and could not check: I was not able to
execute the provider suites locally, so the CI run on this push is the real
signal rather than my word. If you or other maintainers would rather keep the
skip and run these in a dedicated job that installs the extra, I am happy to
switch to that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
