jason810496 commented on code in PR #71054: URL: https://github.com/apache/airflow/pull/71054#discussion_r3726472209
########## airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py: ########## @@ -80,6 +82,27 @@ log = structlog.get_logger(__name__) +# Keys that ``serde.serialize`` refuses at any depth. A ``params_input`` carrying one could not be Review Comment: IMO, we should follow the convetion in XCom and validate at the data model layer: https://github.com/apache/airflow/blob/9a85faa9c55b907bd105ee41567bb7d55dab9f31/airflow-core/src/airflow/api_fastapi/core_api/datamodels/xcom.py#L87-L119 https://github.com/apache/airflow/blob/9a85faa9c55b907bd105ee41567bb7d55dab9f31/shared/serialization/src/airflow_shared/serialization/__init__.py#L20-L44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
