uranusjr commented on code in PR #70805:
URL: https://github.com/apache/airflow/pull/70805#discussion_r3732409838
##########
airflow-core/src/airflow/dag_processing/bundles/manager.py:
##########
@@ -107,6 +108,20 @@ def _bundle_item_exc(msg):
)
[email protected]
Review Comment:
Also this being static means we are parsing the config list twice, once here
and another when `parse_config` is called. This can be dangerous. Maybe
`is_bundle_configured` should be an _instance method_ (with `self`) on the
manager instead and rely on `parse_config` (or a common layer that both it and
`parse_config` reuse).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
