uranusjr commented on code in PR #70805:
URL: https://github.com/apache/airflow/pull/70805#discussion_r3732696550
##########
task-sdk/src/airflow/sdk/coordinators/_subprocess.py:
##########
@@ -385,23 +400,148 @@ class SubprocessCoordinator(BaseCoordinator):
:param task_startup_timeout: Maximum time the coordinator waits for the
subprocess to connect to both servers, in seconds. The default is 10
seconds.
+ :param dag_bundle_name: Locate artifacts through a configured Dag bundle
rather
+ than an explicit root. Mutually exclusive with the subclass's explicit
root;
+ if neither is set, the task's own bundle is used. A named bundle
resolves to
+ its latest version; the task's own bundle is pinned to the run's
version.
"""
task_startup_timeout: float = 10.0
+ dag_bundle_name: str | None = None
+
+ # Name of the subclass's explicit-root kwarg, used only in error messages.
+ # Subclasses that expose an explicit root set this and override
+ # :meth:`_explicit_artifact_roots`; a subclass that does neither lands on
the
+ # task-bundle default instead of failing at execute time.
+ _root_kwarg: ClassVar[str] = "root"
+
+ # Classified once at construction by :meth:`_classify_artifact_source` and
+ # dispatched on by :meth:`_init_root_source` at execute time.
+ _artifact_source: _ArtifactSource | None = attrs.field(init=False,
default=None)
+ # The subclass's explicit root, recorded at construction so the base can
+ # resolve roots without knowing the subclass field name.
+ _configured_roots: list[pathlib.Path] = attrs.field(init=False,
factory=list)
+ # The task's own bundle, bound for the duration of a single
:meth:`execute_task`
+ # call by :meth:`_set_current_bundle` so :meth:`_init_root_source` can
resolve
+ # co-located artifacts.
+ _active_bundle_info: BundleInfo | None = attrs.field(init=False,
default=None)
+
+ @property
+ def _explicit_artifact_roots(self) -> Sequence[pathlib.Path]:
+ """Subclass's explicit artifact roots; empty (the default) selects
task-bundle mode."""
+ return []
+
+ def __attrs_post_init__(self) -> None:
+ self._classify_artifact_source(self._explicit_artifact_roots,
root_kwarg=self._root_kwarg)
Review Comment:
Coding style: The two arguments are probably not needed? This passes two
member attributes to a private member function. The member function can read
those members directly with `self` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
