Lee-W commented on code in PR #70830:
URL: https://github.com/apache/airflow/pull/70830#discussion_r3736645759
##########
providers/common/ai/src/airflow/providers/common/ai/policies/retry.py:
##########
@@ -134,14 +143,19 @@ def __init__(
fallback_rules: list[RetryRule] | None = None,
timeout: float = 30.0,
*,
- redact_exception: bool = True,
+ # redact() is typed for arbitrary containers; a str in always yields a
str out.
+ redactor: Callable[[str], str] | None = lambda message: cast("str",
redact(message)),
Review Comment:
Sounds good. `None` now means "use the default masker", consistent with the
params above it. Disabling redaction using `redact_exception=False`, and
passing that together with an explicit `redactor` raises `ValueError` at
construction time rather than letting one of the two settings quietly win.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
