Lee-W commented on code in PR #70830:
URL: https://github.com/apache/airflow/pull/70830#discussion_r3736652553
##########
providers/common/ai/tests/unit/common/ai/policies/test_retry.py:
##########
@@ -154,6 +154,85 @@ def
test_prompt_keeps_raw_message_when_redaction_disabled(self, mock_hook_cls):
prompt = mock_agent.run_sync.call_args[0][0]
assert secret_value in prompt
+ @pytest.mark.enable_redact
+ @patch("airflow.providers.common.ai.hooks.pydantic_ai.PydanticAIHook",
autospec=True)
+ def test_custom_redactor_replaces_masker_instead_of_stacking(self,
mock_hook_cls):
+ """A custom redactor replaces the secrets masker entirely -- it is not
applied on top."""
+ secret_value = "super-secret-conn-password"
+ mask_secret(secret_value)
Review Comment:
Added `reset_secrets_masker()` to both, matching the siblings above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
