Leondon9 commented on PR #70225:
URL: https://github.com/apache/airflow/pull/70225#issuecomment-5220723331

   This sequencing makes sense. FWIW step 1 — the triggerer changes for 
asset-event fetching — is already implemented in #67941, which independently 
hit the exact issue you flagged: `GetAssetEventByAsset` / 
`GetAssetEventByAssetAlias` aren't handled in the triggerer, and a mocked 
`SUPERVISOR_COMMS` hides it. That PR adds them to the `ToTriggerSupervisor` 
union + dispatch, with a regression test driving the real supervisor path (it 
fails if the union entries are removed).
   
   Its trigger also takes the shape you're describing: natively async (`await 
SUPERVISOR_COMMS.asend(GetAssetEventByAsset(...))`), no `sync_to_async` and no 
`InletEventsAccessor` — so for this narrower partition-only case it doesn't 
need the accessor async-refactor (that refactor is still separately useful if 
the generic sensor routes through the accessor).
   
   Happy for #67941 to serve as that step-1 prerequisite, or for the relevant 
commits to be split/reviewed however fits the plan — whatever keeps this moving.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to