hussein-awala commented on PR #70225: URL: https://github.com/apache/airflow/pull/70225#issuecomment-5309114176
> There are multiple issues with deferrable support. I’d suggest dropping this for now and only implement a synchronous sensor in this PR. After that’s merged, we can > > 1. Introduce triggerer changes needed to support asset event fetching. > 2. Refactor InletEventsAccessor internals to ready it for an async interface. > 3. Add the trigger to depend on the above changes. > 4. Add `deferrable=True` to the sensor that only works on Airflow 3.4+. @uranusjr Thanks, that's a fair catch on the triggerer,`GetAssetEventByAsset` / `GetAssetEventByAssetAlias` aren't available there, so the deferrable path couldn't have worked in practice, and my DB-backed tests hid it because the harness stands in for `SUPERVISOR_COMMS` and runs the execution-API SQL directly. I've dropped deferrable support from this PR: `AssetEventTrigger` and its tests are gone, the shared fetch/count/serialize helpers moved into the sensor module, and the trigger is deregistered from `provider.yaml`. What's left is the synchronous sensor only. That also resolves your point on the example DAG — `process_result=latest_event_only` is fine now that it only ever runs on the worker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
