rino0601 commented on code in PR #71379: URL: https://github.com/apache/airflow/pull/71379#discussion_r3766723743
########## uv.lock: ########## Review Comment: Thanks. I traced the `uv.lock` diff before removing it: it is not an intentional part of the API change. It is reproduced by [the `generate-tasksdk-datamodels` hook](https://github.com/apache/airflow/blob/main/.pre-commit-config.yaml#L1399-L1404), which is triggered by changes under `airflow-core/src/airflow/api_fastapi/execution_api/`. After rebasing onto the latest `main`, running that hook with the CI's `uv 0.11.29` reproduces the exact same `uv.lock` metadata and ordering diff. The hook invokes: `uv run ... --project apache-airflow-task-sdk --directory task-sdk ...` uv 0.11.29 warns that the `--project` directory does not exist but continues. uv 0.12 treats this as an error; I documented that separate compatibility issue in #71377. Removing the lockfile diff from the source-changing commit would require skipping or changing this hook, since it deterministically recreates the diff. A separate revert commit is possible without `--no-verify`, but I have not pushed it yet to avoid another CI run before confirming the preferred resolution. Would you prefer that we fix this hook in this PR, or handle the hook/lockfile behavior in a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
