rino0601 commented on code in PR #71379: URL: https://github.com/apache/airflow/pull/71379#discussion_r3766723743
########## uv.lock: ########## Review Comment: Thanks. I traced the `uv.lock` diff before reverting it: it is not an intentional part of the API change. This PR triggers both [`generate-tasksdk-datamodels`](https://github.com/apache/airflow/blob/main/.pre-commit-config.yaml#L1399-L1404) and [`generate-airflowctl-datamodels`](https://github.com/apache/airflow/blob/main/.pre-commit-config.yaml#L1406-L1418). After rebasing onto the latest `main`, I ran each hook independently with the CI's `uv 0.11.29`; each reproduces the exact same `uv.lock` metadata and ordering diff. Both hooks invoke `uv run` with a `--project` value that is not a project directory, while also supplying the correct `--directory`. uv 0.11.29 warns and continues, but uv 0.12 treats this as an error. I documented that compatibility problem in #71377. To remove this `uv.lock` diff from the API-change commits, I would need to bypass or modify the relevant pre-commit hooks; otherwise, they recreate it deterministically. I do not think bypassing the hooks is the intended resolution here, so I have not pushed the local rebase/revert yet to avoid another CI run before confirming the preferred direction. Would you prefer that I fix the hook behavior in this PR, or keep the lockfile revert here and address the hooks separately in #71377? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
