vincbeck commented on code in PR #71546:
URL: https://github.com/apache/airflow/pull/71546#discussion_r3797860986
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/glue.py:
##########
@@ -447,8 +452,10 @@ def _find_previous_job_run(self, context: Context,
task_uuid: str) -> str | None
self.log.info("Previous Glue job_run_id: %s, state: %s",
previous_job_run_id, state)
if self.is_job_active(state):
return previous_job_run_id
- except Exception:
- self.log.warning("Failed to get previous Glue job run state",
exc_info=True)
+ except ClientError:
Review Comment:
Yeah I would qualify it a bug fix. Catching `Exception` should be prohibited
unless very specific reason so at the end I prefer the version in this PR than
the one in main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
