uranusjr commented on code in PR #68359:
URL: https://github.com/apache/airflow/pull/68359#discussion_r3800051201
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2617,6 +2692,27 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
active_non_backfill_runs=active_runs_of_dags[dag_model.dag_id],
)
+ if data_interval is not None:
Review Comment:
This guard duplicates the `if new_info.data_interval is None: return None`
check inside `_collect_skipped_intervals`. Since `data_interval` is just
`next_info.data_interval`, the two test the same value.
I would suggest dropping the outer if and letting the callee own its own
precondition; the internal check is worth keeping since the method is
unit-tested directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
