ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364240075
 
 

 ##########
 File path: tests/jobs/test_scheduler_job.py
 ##########
 @@ -2034,7 +2034,7 @@ def test_dagrun_root_fail_unfinished(self):
             ti = dr.get_task_instance('test_dagrun_unfinished', 
session=session)
             ti.state = State.NONE
             session.commit()
-        dr_state = dr.update_state()
+        dr_state = dr.state
 
 Review comment:
   This looks suspect -- I would expect it to be
   ```suggestion
           dr.update_state()
           dr_state = dr.state
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to