ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected 
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r367147759
 
 

 ##########
 File path: tests/models/test_dagrun.py
 ##########
 @@ -234,8 +234,9 @@ def test_dagrun_deadlock(self):
         ti_op2.set_state(state=State.NONE, session=session)
 
         dr.update_state()
-        self.assertEqual(dr.state, State.RUNNING)
+        self.assertEqual(dr.state, State.FAILED)
 
 Review comment:
   I'm still not 100% on this change. I'll hope to look at this tomorrow 
(because otherwise I'll merge https://github.com/apache/airflow/pull/6792/files 
which is going to cause a number of conflicts for one of us)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to